-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find a proper name for the library #132
Comments
I vote for keeping a name that describes per se the goal of the library. In this case, What about |
I quite like |
we must remember it is JS/TS library, in this word name of libraries do not have to be connected directly with library purpose: angular, gulp, grunt, vue, etc. modeller looks strange when you write it, it is not even a word 😄 |
Those that you mentioned are not related to any project. They work independently, meaning it makes sense to choose a unique and inventive name people can remember and know always about what they talk about.
https://www.collinsdictionary.com/dictionary/english/modeller
Me, as a user of AsyncAPI, won't look ever by |
that is the thing, library can but doesn't have to be used with AsyncAPI, can be used directly with JSON Schema, which makes it applicable everywhere else. As Maciek stated in description, Anyway,
my bad I'm with we need someone for final decision 😄 |
From the README.md:
If the goal is to make it agnostic of AsyncAPI soon, we should write that down and modify the README. |
just to make sure, for me, it is already agnostic if I do not need AsyncAPI and can use JSON Schema directly. I'm more interested in fact why we support AsyncAPI and probably could do OpenAPI too. Why not using parser (I anyway have to use it) to get all schemas and then iterate over with modelina? What is the advantage of such an approach @magicmatatjahu @jonaslagoni ? |
The library is built to support multiple inputs (any input actually, such as OpenAPI, but could also be typescript files and so on). We just dont support anything other then AsyncAPI and JSON Schema draft 7 at the moment, because there has not been added any processors to handle it https://github.com/asyncapi/generator-model-sdk/blob/da68fa0a8b8511e6598be39e03553d4df02d6309/src/processors/InputProcessor.ts#L15 @derberg You can use the parser directly, especially if you want to decide which schemas are generated or any other reason. If you just provide the AsyncAPI document it will generate models for all your messages but not lonely schemas. So it all depends on your use-case, what is easier for you to use. |
|
I dislike generator-model-sdk, it is something you can not use freely while speaking. |
I also like Modelina. Modeller, meh! Kinda but don't really buy it 😄 |
generator-model-sdk
can be confusing for someone in AsyncAPI community and also for people outside the community. It doesn't need the generator to work, it's a standalone library like QuickType, so we should change name of the repo and project. Any ideas?My proposition is
Modelina
. It is a polish word formodelling clay
. There is possible to form something (models) out of modeling clay (input data) - like in programming 🤣 . And themodel
is also in the name :)The text was updated successfully, but these errors were encountered: