Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OpenAPI Schema parser (TS version) back from parser-js 2.0 to this repo #140

Closed
smoya opened this issue Oct 11, 2022 · 5 comments · Fixed by #142
Closed

Move OpenAPI Schema parser (TS version) back from parser-js 2.0 to this repo #140

smoya opened this issue Oct 11, 2022 · 5 comments · Fixed by #142
Assignees
Labels
enhancement New feature or request

Comments

@smoya
Copy link
Member

smoya commented Oct 11, 2022

Reason/Context

Parser-JS 2.0 (released as rc at this moment) is a completely new parser, with a lot of changes. The bigger ones are:

  • Completely rewritten to TS.
  • Implements the new parser-api, in particular, the version found in this PR.
  • Uses Spectral as parser/linter with the AsyncAPI ruleset.
  • Lots of other improvements, especially around Developer Experience.

Considering that Spectral now validates the documents before parsing, we had to update the interface for Schema parsers to separate validation from parsing. This change also introduced better errors and the way we handle them. (see this issue and related).

FYI, Spectral addition was discussed starting in asyncapi/parser-js#481 (comment), ending in asyncapi/parser-js#481 (comment). Also asyncapi/parser-js#477 (comment). Also during some 3.0 meetings.

To not pollute every single schema parser repository and to simplify development, the schema parsers have been temporarily included in the same source code as the Parser-JS 2.0. Once tested, the idea is to move those back to their own repositories.

Description

The work to be done is to move back this schema parser from https://github.com/asyncapi/parser-js/tree/next-major/src/schema-parser to this repository.

This includes:

  • Copy-pasting the schema parser code from the Parser-JS 2.0 next-major repository to this one.
  • Enable Typescript compilation.
  • To release a new major version, since the interface has changed.

Please feel free to drop your questions and concerns.

cc @derberg @fmvilas @magicmatatjahu

@smoya smoya added the enhancement New feature or request label Oct 11, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Oct 19, 2022

oh my, I'm a code owner here 😭 anyone interested in taking over 😢

@smoya
Copy link
Member Author

smoya commented Oct 20, 2022

oh my, I'm a code owner here 😭 anyone interested in taking over 😢

"A wild code owner appears!" https://github.com/asyncapi/openapi-schema-parser/pull/142/files#diff-fcf14c4b7b34fe7a11916195871ae66a59be87a395f28db73e345ebdc828085b

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 18, 2023
@smoya
Copy link
Member Author

smoya commented Mar 15, 2023

you bot remove the stale label now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants