Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper usage of parser on extensions and sample readme #47

Merged
merged 3 commits into from Feb 10, 2021

Conversation

SebastienAndreo
Copy link
Contributor

Description

Related issue(s)
Resolves #32

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@SebastienAndreo SebastienAndreo changed the title fixing #32 fix:#32 Feb 9, 2021
@SebastienAndreo SebastienAndreo changed the title fix:#32 fix: #32 Feb 9, 2021
@derberg derberg changed the title fix: #32 fix: proper usage of parser on extensions and sample readme Feb 9, 2021
samples/README.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Feb 9, 2021

@SebastienAndreo thanks a lot for this PR. I suggested some improvement to the readme (more prerequisites, usage of files from remote locations, no need to docker pull as docker run will pull if image not present)

one thing that could be improved in the future is the last step, the config file. Generator could handle and generate config.ini with proper values. AsyncAPI supports servers information and data like host or port can be added there, and then generator can read this information and put it in the config.ini

@derberg
Copy link
Member

derberg commented Feb 9, 2021

@SebastienAndreo if you agree with my suggestion you need to apply it by choosing commit suggestion

SebastienAndreo and others added 2 commits February 10, 2021 12:29
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit c73c6da into asyncapi:master Feb 10, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python-paho-template doesn't work with latest RC of @asyncapi/generator
3 participants