chore: add Cameron Rushton to CODEOWNERS #89
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@damaru-inc please change title as such change should not really trigger a release to npm @CameronRushton please approve @damaru-inc @fmvilas should me and Fran stay in the file, maybe we should step down? |
|
What change should I make to the title so that it passes the Lint test? I thought it had to start with fix: or feat: or something like that. As for removing you and Fran, I'll leave that up to you. |
|
all most common prefixes are here https://github.com/asyncapi/.github/blob/master/CONTRIBUTING.md#conventional-commits |
damaru-inc
changed the title
|
Thanks, I was having trouble finding that document... |
|
Yeah, I don't think I deserve to be a maintainer of this repo, I've never made any contribution as far as I remember 🤔 Happy to help though. |
|
@fmvilas I think it is better if we are removed to give more freedom to folks and if ever needed, some second opinion or special review, they can always count on us. @damaru-inc I say you remove us |
|
Yeah, go ahead and remove us. We also have to be fair and we didn't do any merits to be maintainers of this repo :) |
|
That's fine, but could one of you please approve this PR first, so that Cameron can approve my other PR? Then I'll remove you. Thanks! |
|
@damaru-inc you can remove us now, and I will merge as Admin |
|
🎉 This PR is included in version 0.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@damaru-inc I think you forgot about the proper prefix in the commit message 😄 |
|
Doh! You're right, I just fixed the PR title. But that's not what's causing the issue of us not being able to merge the other PR, is it? |
Description
This is a request to add Cameron Rushton to CODEOWNERS.