feat: initial desktop starting environment #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/bin/cli.js
NektariosFifes
requested review from
jonaslagoni and
asyncapi-bot-eve
as code owners
NektariosFifes
changed the title
jonaslagoni
reviewed
Mar 16, 2022
|
i dont know why that is present. I thought i deleted it but it persists .i will remove it. @jonaslagoni |
|
@jonaslagoni ok removed it |
jonaslagoni
previously approved these changes
Mar 16, 2022
jonaslagoni
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
jonaslagoni
approved these changes
Mar 17, 2022
jonaslagoni
reviewed
Mar 17, 2022
| @@ -38,7 +39,8 @@ | |||
| "commander": "^7.2.0", | |||
| "cross-env": "^7.0.3", | |||
| "js-yaml": "^3.14.1", | |||
| "randexp": "^0.5.3" | |||
| "randexp": "^0.5.3", | |||
| "run-script": "^0.1.1" | |||
There was a problem hiding this comment.
@NektariosFifes not sure why you use this. But be careful when using dependencies with such a low activitiy.
Easy to introduce vulnerabilities
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Progresses#94