Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: application icons and project details #107

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

NektariosFifes
Copy link
Collaborator

Description

  • Added different icon versions for application installation and runtime logo
  • Added details regarding project in package.json

Related issue(s)

#88

Added project details
update package-lock.json
@NektariosFifes NektariosFifes changed the title Application icons and project details feat: application icons and project details Mar 20, 2022
@@ -1,12 +1,12 @@
{
"name": "electron-react-boilerplate",
"name": "async-api-simulator",
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  "name": "asyncapi-simulator",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand when i go to the branch on my repo desktop/release/app/packages.json is correct. The pull request is not showing it correctly.

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NektariosFifes NektariosFifes merged commit 830fef1 into asyncapi:master Mar 21, 2022
@NektariosFifes NektariosFifes deleted the icons_AndDetails branch March 21, 2022 13:42
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants