feat: initial application layout #114
Conversation
# Conflicts: # src/bin/cli.js
Added project details
# Conflicts: # Desktop/src/renderer/App.tsx
NektariosFifes
changed the title
NektariosFifes
requested review from
jonaslagoni and
asyncapi-bot-eve
as code owners
|
@jonaslagoni should i split it in a smaller commit? |
There was a problem hiding this comment.
Going forward don't put everything in one PR, I would rather have 100 small PRs than one large 😄 There is no way I can help you out properly as there are too many changes to keep track of. Up to you if you want to split it up.
You have a lot of disabled eslint lines. They are there for a reason, among other reasons to create consistency. Some of them can be a bit of a pain, and in some cases, they might not be needed, but I can't seem to figure out why all of them are needed here?
Each time you need to disable something, try and second guess why you need to disable them. You can always suggest changing the eslint config, but remember to have your arguments in order why a consistency is not needed, etc 😄
|
i will remove eslints |
added some missing typescript definitions various other fixes
… sizing of icon in app.
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
The following components without functionality have been added.
Also added the app icon that was missing.
Also updated certain typescript definitions.
Related issue(s)
progresses #88