Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure headers must be object type #396

Merged
merged 2 commits into from
Jun 17, 2020
Merged

fix: make sure headers must be object type #396

merged 2 commits into from
Jun 17, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Jun 16, 2020

Description

now validation fails with:

"headers": {
    "type": "integer",
    "enum": [1, 2]
}

but it is allowing:

"headers": {
    "type": "object",
    "properties": {
      "my-app-header": {
        "type": "integer",
        "minimum": 0,
        "maximum": 100
      }
    }
  }

Related issue(s)
See also asyncapi/parser-js#68

Comment
I assume that once this is merged, I also need to create a PR to asyncapi-node. See also #395

@derberg derberg requested a review from fmvilas June 16, 2020 11:20
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just left a suggestion.

versions/2.0.0/schema.json Outdated Show resolved Hide resolved
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@derberg
Copy link
Member Author

derberg commented Jun 16, 2020

@fmvilas good point, const is better, have a look now

@derberg derberg merged commit b5a2622 into asyncapi:master Jun 17, 2020
@derberg derberg deleted the headers branch June 17, 2020 13:57
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member Author

derberg commented May 24, 2021

It is actually not included in the release. This was an unintentional release caused by the release automation initial run. 1.0 version of the spec was released a long time ago. The release mentioned by the bot was removed.

@derberg derberg removed the released label May 24, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants