Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SNS support would be great #40

Closed
SkippyZA opened this issue Oct 23, 2017 · 4 comments
Closed

AWS SNS support would be great #40

SkippyZA opened this issue Oct 23, 2017 · 4 comments

Comments

@SkippyZA
Copy link

SkippyZA commented Oct 23, 2017

Currently covering our topics with this and it would be great to have some official SNS support

edit: incorrectly used sqs instead of sns

@SkippyZA SkippyZA changed the title AWS SQS support would be great AWS SNS support would be great Oct 23, 2017
@fmvilas
Copy link
Member

fmvilas commented Oct 23, 2017

Hey! Thanks for pointing out. As per documentation AWS SNS is not a protocol but a product supporting many protocols:

The protocol you want to use. Supported protocols include:

* http -- delivery of JSON-encoded message via HTTP POST
* https -- delivery of JSON-encoded message via HTTPS POST
* email -- delivery of message via SMTP
* email-json -- delivery of JSON-encoded message via SMTP
* sms -- delivery of message via SMS
* sqs -- delivery of JSON-encoded message to an Amazon SQS queue
* application -- delivery of JSON-encoded message to an EndpointArn for a mobile app and device.
* lambda -- delivery of JSON-encoded message to an AWS Lambda function.

http://docs.aws.amazon.com/sns/latest/api/API_Subscribe.html

So in which protocol would you be interested?

@fmvilas
Copy link
Member

fmvilas commented Oct 30, 2017

I'm closing the issue as it's already a week old without response. Feel free keep commenting.

@fmvilas fmvilas closed this as completed Oct 30, 2017
@SkippyZA
Copy link
Author

Somehow my notification for this went missing.

So while SNS does support multiple methods to subscribe to it, that I see is some 'implementation' logic. At the very least, the ability to specify that the API is SNS. Perhaps have the ability so specify the account id, region etc would be great. This could perhaps be used to build up the ARN?

With regards to consuming a message, I believe the event data will be the same regardless of which approach you use to subscribe to it.

I have also tried the approach of setting the base topic to represent the ARN, but when it joins the actual stream, it uses a . and not : needed for the arn resulting in: arn:aws:sns:{region}:{accountId}.TopicName

@fmvilas
Copy link
Member

fmvilas commented Oct 30, 2017

I think your best friend here is Specification Extensions.
This way you can specify whatever custom properties you might need:

x-sns-region: 'us-east-1'
x-sns-accountId: 'your-account-id-here'

The only thing you'd have to do is to tweak documentation generator and/or code generator to use those values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants