Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change examples structure #436

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

BlockLucas
Copy link
Contributor

Now examples facet for Message & Message Trait objects are an array of any
Fixes #410

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor tweaks to convey with spec language. Thanks a lot, @BlockLucas!

versions/2.0.0/asyncapi.md Outdated Show resolved Hide resolved
versions/2.0.0/asyncapi.md Outdated Show resolved Hide resolved
BlockLucas and others added 2 commits September 7, 2020 14:33
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@BlockLucas
Copy link
Contributor Author

Thanks, @fmvilas!
Suggestions applied

@fmvilas
Copy link
Member

fmvilas commented Sep 9, 2020

Awesome! Thanks, @BlockLucas!

@fmvilas fmvilas merged commit 61fdd01 into asyncapi:master Sep 9, 2020
BlockLucas added a commit to BlockLucas/tck that referenced this pull request Sep 14, 2020
fmvilas added a commit that referenced this pull request Sep 21, 2020
fmvilas added a commit that referenced this pull request Sep 21, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message object examples facet has a wrong type
3 participants