Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change examples structure" #444

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Sep 21, 2020

Reverts #436

@BlockLucas Sorry man, I messed it up the other day. The spec was correct but unclear: asyncapi/html-template#59 (comment).

We should still keep that Whatever "any" is, it MUST match the type defined on the payload. but slightly rephrased because it can be headers or payload. We should also make it clear that the "string" in "[Map[string, any]]" can actually only be either headers or payload.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas fmvilas merged commit adbe91b into master Sep 21, 2020
@fmvilas fmvilas deleted the revert-436-change-examples-structure branch September 21, 2020 15:50
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

1 similar comment
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants