Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change minItems of oneOf and anyOf to 1 #493

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: change minItems of oneOf and anyOf to 1 #493

merged 1 commit into from
Feb 4, 2021

Conversation

Z5eyhS0uubejR0SVmX2O
Copy link
Contributor

Description
I briefly created a test action to test this change, but found there are some existing actions that just didn't run in my fork. I'm hoping that automated testing is performed when I open this PR. I don't have a Node environment setup so was intending to use CI to test.

Related issue(s)
Resolves #492

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Z5eyhS0uubejR0SVmX2O Z5eyhS0uubejR0SVmX2O changed the title Change minItems of oneOf and anyOf to 1 fix: Change minItems of oneOf and anyOf to 1 Feb 2, 2021
@Z5eyhS0uubejR0SVmX2O Z5eyhS0uubejR0SVmX2O changed the title fix: Change minItems of oneOf and anyOf to 1 fix: change minItems of oneOf and anyOf to 1 Feb 2, 2021
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@derberg
Copy link
Member

derberg commented Feb 4, 2021

failing test will be fixed with #495

@derberg derberg merged commit 3b78c1d into asyncapi:master Feb 4, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-2021-06-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jun 15, 2021

Not included in release 2.1 yet, 2.1 was mistakenly triggered by our automation.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] oneOf and similar tools unexpectedly require 2 or more items
3 participants