Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add requirement for updating JSON Schema when contributing #530

Merged
merged 1 commit into from
Apr 20, 2021
Merged

fix: add requirement for updating JSON Schema when contributing #530

merged 1 commit into from
Apr 20, 2021

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 19, 2021

Updating contribution guide as there is a bug that makes only JS Parser a requirement for introducing changes in the spec. JSON Schema is moved to a separate repo and it also must be updated as JS Parser depends on it. So no other option here, you have to accept this PR @fmvilas 馃槃

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg requested a review from fmvilas April 20, 2021 08:37
@derberg derberg merged commit d934ab9 into asyncapi:master Apr 20, 2021
@derberg derberg deleted the fix-contribition-guide branch April 20, 2021 09:07
@asyncapi-bot
Copy link
Contributor

馃帀 This PR is included in version 1.0.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@derberg
Copy link
Member Author

derberg commented May 24, 2021

It is actually not included in the release. This was an unintentional release caused by the release automation initial run. 1.0 version of the spec was released long time ago. The released mentioned by the bot was removed.

@derberg derberg removed the released label May 24, 2021
@asyncapi-bot
Copy link
Contributor

馃帀 This PR is included in version 2.1.0-2021-06-release.1 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@asyncapi-bot
Copy link
Contributor

馃帀 This PR is included in version 2.1.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@derberg
Copy link
Member Author

derberg commented Jun 15, 2021

Not included in release 2.1 yet, 2.1 was mistakenly triggered by our automation.

@asyncapi-bot
Copy link
Contributor

馃帀 This PR is included in version 2.1.0 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants