Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release for version 2.5.0 of the spec #842

Merged
merged 10 commits into from
Sep 29, 2022
Merged

feat: release for version 2.5.0 of the spec #842

merged 10 commits into from
Sep 29, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Sep 28, 2022

Refs #830

Features

Fixes

Resolves #775
Resolves #465
Resolves #654

@char0n
Copy link
Collaborator Author

char0n commented Sep 28, 2022

Here are the release notes for the 2.5.0 version of the spec that should be used for the GitHub Release.

Release notes article -> https://www.asyncapi.com/blog/release-notes-2.5.0

Features
---
- Server Variables can be now referenced from inside the Server Object (#776) ([5deef1e](https://github.com/asyncapi/spec/commit/5deef1e9148947689d53db3a1d013d49cd9df7d0)), resolves #775 by @char0n 
- Decorating Server Object with tags (#809) ([b0c2f9c](https://github.com/asyncapi/spec/commit/b0c2f9c086d940e8016ec1fa60107fe74cc070db)), resolves #654, resolves #465 by @smoya
- Added new Google Cloud Pub/Sub Bindings (#836) ([babc3be](https://github.com/asyncapi/spec/commit/babc3bedb5d85375a305c7268e96257113c1933e)) ([binding definition](https://github.com/asyncapi/bindings/tree/master/googlepubsub)) by @whitlockjc 
- Added schema registry infos to Kafka binding ([#115](https://github.com/asyncapi/bindings/pull/115)) ([binding definition](https://github.com/asyncapi/bindings/tree/master/kafka)) by @lbroudoux
- Other enhancements
  - Clarified ChannelItem.$ref resolution rules (#779) ([9a293c7](https://github.com/asyncapi/spec/commit/9a293c77f6bf74a056a8845dabfbe20e73a6f320)), resolves #612 by @char0n
  - Clarification around URL resolution rules (#782) ([fc324ef](https://github.com/asyncapi/spec/commit/fc324ef3aa92d313918a00ea9a5eb6c85720a36d)), resolves #674 by @char0n
  - Align wording with [RFC 2119](https://www.rfc-editor.org/rfc/rfc2119) (#818) ([5580a9c](https://github.com/asyncapi/spec/commit/5580a9c5fbef55e925e7514b986c95a0e4c85821)) by @char0n

Fixes
---
- Added missing IBM MQ Operation Binding (#840) ([68d85d1](https://github.com/asyncapi/spec/commit/68d85d19e5be12fa6e13d0fc5851993934dbdcde)) ([binding definition](https://github.com/asyncapi/bindings/tree/master/ibmmq#operation-binding-object)), refs [#605](https://github.com/asyncapi/spec/issues/605) by @magicmatatjahu

Full Changelog: https://github.com/asyncapi/spec/compare/v2.4.0...v2.5.0

@char0n char0n mentioned this pull request Sep 28, 2022
61 tasks
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@char0n thanks so much man for your support and all the efforts to get shit done 🍻

@fmvilas @dalelane please make final approval for the release

@char0n
Copy link
Collaborator Author

char0n commented Sep 28, 2022

/dnm

@char0n
Copy link
Collaborator Author

char0n commented Sep 28, 2022

/au

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🍺 Great stuff!

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@char0n
Copy link
Collaborator Author

char0n commented Sep 29, 2022

@fmvilas @smoya @derberg @dalelane this is good to go. According to https://github.com/asyncapi/spec/blob/master/RELEASE_PROCESS.md#step-13---merge-the-release-branches, one of the code owner should merge this PR. Can I ask one of you to merge this PR?

Updated release notes to be used for GitHub release are in: #842 (comment)

Thank you!

@derberg derberg merged commit 4ed4055 into master Sep 29, 2022
@derberg derberg deleted the next-spec branch September 29, 2022 06:49
@derberg derberg restored the next-spec branch September 29, 2022 06:49
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Sep 29, 2022

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants