-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot load http://json-schema.org/draft-07/schema #146
Comments
The problem is in https://github.com/asyncapi/spec-json-schemas/blob/master/schemas/2.2.0.json#L3 line, monaco-yaml try to resolve all external schemas from given version of AsyncAPI spec, so I think that we should create PR for specs, not for Studio. |
What about using always |
I had in mind that when I wrote my comment 😄 |
A PR has been created with the fix asyncapi/spec-json-schemas#115. Once merged, I guess we will need to redeploy the Studio so It loads all fresh schemas. |
Describe the bug
Current version of the Studio can't load http://json-schema.org/draft-07/schema when deployed in production.
![Warning](https://user-images.githubusercontent.com/1083296/139251019-742bcc6b-4864-4c89-8eef-9e85fe69d90b.png)
This causes a warning on the editor such as:
How to Reproduce
Go to https://studio.asyncapi.com and load any AsyncAPI File.
Expected behavior
Warning should not be there.
The error is due to the fact the app is trying to load a
http
resource when the whole HTML has been loaded throughhttps
. This is illegal. In fact, the developer console is pretty clear:It seems we can provide a valid schema via
monaco-yaml
settings: https://github.com/remcohaszing/monaco-yaml/blob/main/index.d.ts#L4-L25The text was updated successfully, but these errors were encountered: