Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalid key error to Studio #728

Closed
Mrc0113 opened this issue Jul 7, 2023 · 4 comments
Closed

Add invalid key error to Studio #728

Mrc0113 opened this issue Jul 7, 2023 · 4 comments
Labels
bug Something isn't working stale

Comments

@Mrc0113
Copy link

Mrc0113 commented Jul 7, 2023

Describe the bug

The error message for an invalid key is vague. It would be ideal if a key did not use required characters [a-zA-Z0-9\.\-_]+$ it should immediately be an error stating invalid key.

I am unsure if this is an issue in the studio itself or the parser.

How to Reproduce

  1. Navigate to AsyncAPI Studio w/ default example loaded
  2. Replace all "turnOnOff" with "turn On Off"
  3. See diagnostics shows 2 errors stating "Referencing in this place is not allowed"

Slack conversation: https://asyncapi.slack.com/archives/C34F2JV0U/p1688058753622989

Expected behavior

It would be ideal if a key did not use required characters [a-zA-Z0-9\.\-_]+$ it should immediately be an error stating invalid key.

@Mrc0113 Mrc0113 added the bug Something isn't working label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Amzani
Copy link
Collaborator

Amzani commented Jul 11, 2023

@Mrc0113 not related to studio, a new rule should be added to spectral, I've created an issue here: stoplightio/spectral#2503

@Mrc0113
Copy link
Author

Mrc0113 commented Jul 25, 2023

Thank you @Amzani

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 23, 2023
@Amzani Amzani closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
Archived in project
Development

No branches or pull requests

2 participants