Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre-commit #75

Merged
merged 4 commits into from May 26, 2020
Merged

Introduce pre-commit #75

merged 4 commits into from May 26, 2020

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented May 21, 2020

…so that CI and developers can run the very same QA checks and things stay clean.

pre-commit is up here and kicks ass. To give it a try as a Git pre-commit hook locally:

git clone --branch introduce-pre-commit https://github.com/hartwork/django-easy-select2
cd django-easy-select2
virtualenv --python=python3.7 py37
source py37/bin/activate
pip install pre-commit
pre-commit install --install-hooks

Prior to activation, you can see the very same GitHub Action over here:
https://github.com/hartwork/django-easy-select2/actions

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 801cc6d on hartwork:introduce-pre-commit into bc84f73 on asyncee:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 801cc6d on hartwork:introduce-pre-commit into bc84f73 on asyncee:master.

@hartwork
Copy link
Collaborator Author

I'd be happy to discuss this pull request. Any thoughts?

@asyncee
Copy link
Owner

asyncee commented May 26, 2020

Sorry for delay, lgtm. Thank you!

@asyncee asyncee merged commit 920fa95 into asyncee:master May 26, 2020
@asyncee
Copy link
Owner

asyncee commented May 26, 2020

Would you like to become a collaborator?

asyncee added a commit that referenced this pull request Jul 2, 2020
asyncee added a commit that referenced this pull request Jul 2, 2020
@hartwork hartwork added this to the 1.5.8 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants