coveralls: Stop using discouraged "--service=github" #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
added a commit
that referenced
this pull request
Feb 7, 2022
.. so that it stops complaining about missing
variable GITHUB_TOKEN ..
> Running on Github Actions but GITHUB_TOKEN is not set.
> Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to
> your step config.
(which may have write access) and that we stopped
sharing with coveralls in PR #97.
The related code checks for presence of variable
GITHUB_ACTIONS so we we take that variable
from coveralls-python.
Rather than excluding variable GITHUB_ACTIONS,
we include all other GITHUB_* variables used by
coveralls-python. The list was derive like this:
$ git clone --depth 1 https://github.com/TheKevJames/coveralls-python
$ cd coveralls-python/
$ git grep -oh "GITHUB_[^ ':\`*]\+" | sort -u
GITHUB_ACTIONS
GITHUB_HEAD_REF
GITHUB_REF
GITHUB_REPOSITORY
GITHUB_RUN_ID
GITHUB_RUN_NUMBER
GITHUB_SHA
GITHUB_TOKEN
hartwork
added a commit
that referenced
this pull request
Feb 7, 2022
.. so that it stops complaining about missing
variable GITHUB_TOKEN ..
> Running on Github Actions but GITHUB_TOKEN is not set.
> Add "env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}" to
> your step config.
(which may have write access) and that we stopped
sharing with coveralls in PR #97.
The related code checks for presence of variable
GITHUB_ACTIONS so we we take that variable
from coveralls-python.
Rather than excluding variable GITHUB_ACTIONS,
we include all other GITHUB_* variables used by
coveralls-python. The list was derived list this:
$ git clone --depth 1 https://github.com/TheKevJames/coveralls-python
$ cd coveralls-python/
$ git grep -oh "GITHUB_[^ ':\`*]\+" | sort -u
GITHUB_ACTIONS
GITHUB_HEAD_REF
GITHUB_REF
GITHUB_REPOSITORY
GITHUB_RUN_ID
GITHUB_RUN_NUMBER
GITHUB_SHA
GITHUB_TOKEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
lemurheavy/coveralls-public#1607 (comment)
CC @asyncee @afinetooth