Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Checkstyle #208

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Implementing Checkstyle #208

merged 1 commit into from
Feb 28, 2024

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Jan 19, 2024

Motivation:
To ensure code consistency and quality through the adoption of Checkstyle

Modification:
Added Checkstyle plugin and configuration, updated code to comply with new coding standards.
Set version as INTERNAL on internal modules

Result:
Enhanced code quality and consistency across the project, facilitating easier contributions and maintenance.

@jchrys jchrys added the enhancement New feature or request label Jan 19, 2024
@jchrys jchrys added this to the 1.1.1 milestone Feb 6, 2024
@mirromutth
Copy link
Contributor

Is there any new progress? I suggest moving this PR to 1.1.3.

@jchrys
Copy link
Collaborator Author

jchrys commented Feb 22, 2024

Is there any new progress? I suggest moving this PR to 1.1.3.

Got it. Let me move this and others.

@jchrys jchrys modified the milestones: 1.1.2, 1.1.3 Feb 22, 2024
@jchrys
Copy link
Collaborator Author

jchrys commented Feb 22, 2024

Is there any new progress? I suggest moving this PR to 1.1.3

@mirromutth
Done. I believe you're ready to release (I sent you the necessary credentials earlier this year via email) feel free to let me know if you don't have oneIf you don't have them, please inform me, and I'll be happy to assist with the release process.

Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Motivation:
To ensure code consistency and quality through the adoption of Checkstyle

Modification:
Added Checkstyle plugin and configuration, updated code to comply with new coding standards.
Set version as INTERNAL on internal modules

Result:
Enhanced code quality and consistency across the project, facilitating easier contributions and maintenance.
@jchrys jchrys merged commit 140c634 into trunk Feb 28, 2024
15 checks passed
@jchrys jchrys deleted the 1x-checkstyle branch February 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants