Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deploy #250

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix Deploy #250

merged 1 commit into from
Feb 28, 2024

Conversation

jchrys
Copy link
Collaborator

@jchrys jchrys commented Feb 28, 2024

Motivation:
Deploy Failure

Modification:
Prepare internal dependencies before deploy

Result:
Fix
Resolves #249

@jchrys
Fix Deploy
61ee48e 
Motivation:
Deploy Failure

Modification:
Prepare internal dependencies before deploy

Result:
Fix
Resolves #249
@jchrys jchrys added the bug Something isn't working label Feb 28, 2024
@jchrys jchrys marked this pull request as ready for review February 28, 2024 03:11
mirromutth
mirromutth approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for miss checking, my bad, it seems good

@mirromutth mirromutth merged commit f8832dc into trunk Feb 28, 2024
15 checks passed
@mirromutth mirromutth deleted the 1x-fix-deploy branch February 28, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirromutth mirromutth mirromutth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]Fix Snapshot deployment
2 participants
@jchrys @mirromutth