Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct transaction statement building #252

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Correct transaction statement building #252

merged 1 commit into from
Feb 29, 2024

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Feb 29, 2024

Motivation:

Currently, START TRANSACTION does not allow READ ONLY and WITH CONSISTENT SNAPSHOT to be used at the same time. Multiple transaction properties need to be separated by commas. e.g. START TRANSACTION WITH CONSISTENT SNAPSHOT, READ ONLY

Modification:

  • Correct transaction statement building
  • Correct incorrect description in javadoc of MySqlTransactionDefinition
  • Add unit test for transaction statement building
  • Add integration test for start transaction with consistent and read only

Result:

READ ONLY and WITH CONSISTENT SNAPSHOT can be used simultaneously in a transaction.

@mirromutth mirromutth added the bug Something isn't working label Feb 29, 2024
@mirromutth mirromutth added this to the 1.1.3 milestone Feb 29, 2024
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, but I do have one question.

Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mirromutth mirromutth merged commit 3f119eb into trunk Feb 29, 2024
15 checks passed
@mirromutth mirromutth deleted the fix/transaction branch February 29, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants