Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent spelling style #262

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Consistent spelling style #262

merged 1 commit into from
Mar 15, 2024

Conversation

mirromutth
Copy link
Contributor

@mirromutth mirromutth commented Mar 15, 2024 •
edited
Loading

Motivation:

Consistent English spelling style, change Parametrized (British) -> Parameterized (US)

Modification:

It causes ParametrizedCodec to be changed to ParameterizedCodec, it should be fine.

  • Almost no one uses ParametrizedCodec
  • We are trying to mark getting an object using ParameterizedType as an unstable API

Result:

Consistent English spelling style.

@mirromutth mirromutth added this to the 1.1.3 milestone Mar 15, 2024
@mirromutth mirromutth requested a review from jchrys March 15, 2024 06:22
@mirromutth mirromutth marked this pull request as ready for review March 15, 2024 06:23
jchrys
jchrys approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit 3e70b4a into trunk Mar 15, 2024
15 checks passed
@mirromutth mirromutth deleted the spell/parameterized branch March 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchrys jchrys jchrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mirromutth @jchrys