Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast path for determining Codec #263

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

mirromutth
Copy link
Contributor

Motivation:

Improve Codec selection.

See #153

Modification:

  • Add Codec.getMainClass() for fast path, it allows users to extend Codec to change fast path
  • Add fast path to default codecs
  • Merge primitive type fast path into new fast path

Result:

The selection improved

@mirromutth mirromutth added the enhancement New feature or request label Mar 15, 2024
@mirromutth mirromutth added this to the 1.1.3 milestone Mar 15, 2024
@mirromutth mirromutth requested a review from jchrys March 15, 2024 11:29
@mirromutth mirromutth linked an issue Mar 15, 2024 that may be closed by this pull request
- Add `Codec.getMainClass()` for fast path, it allows users to extend `Codec` to change fast path
- Add fast path to default codecs
- Merge primitive type fast path into new fast path
@mirromutth mirromutth force-pushed the 153-improved-decoder-selection branch from 32f4b54 to 9e18aad Compare March 15, 2024 11:31
@mirromutth mirromutth marked this pull request as ready for review March 15, 2024 11:33
Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mirromutth mirromutth merged commit d533e1e into trunk Mar 18, 2024
15 checks passed
@mirromutth mirromutth deleted the 153-improved-decoder-selection branch March 18, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Decoder Selection
2 participants