Use latest maven #84
Merged
Use latest maven #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Better use latest maven Modification: Use Maven 3.9.1 to build & test Result: up-to-date with Maven
saurabhyadav1985
pushed a commit
to saurabhyadav1985/r2dbc-mysql
that referenced
this pull request
Apr 9, 2023
Trim POM to remove inactive developers Motivation: To keep the developer list up-to-date. Modifications: Remove inactive developers Result: POM file is up-to-date. Removing WError argument Move github specific files inside `.github` Motivation: Better maintain github specific files in `.github` Modifications: Moved CODE_OF_CONDUCT.md and CONTRIBUTING.md inside `.github` Results: Clean up Update issue templates Use variable to store DB_PASSWORD Motivation: DB_PASSWORD is not a secret variable since it is used only to test. Modifications: Use Github variables to store DB_PASSWORD Results: Better Repository Structure. Change RetentionPolicy to RUNTIME in NotNullByDefault annotation Motivation: The NotNullByDefault annotation was originally set with a RetentionPolicy of CLASS, which means it is only available during compile-time. However, we want it to be available during runtime as well, so we can use it for null-checking in Kotlin. Modifications: Changed the RetentionPolicy of the NotNullByDefault annotation from CLASS to RUNTIME. Result: The NotNullByDefault annotation can now be used for null-checking in Kotlin during both compile-time and runtime. [maven-release-plugin] prepare release r2dbc-mysql-1.0.0 [maven-release-plugin] prepare for next development iteration Update README Motivation: Released v1.0.0 Modifications: Changed Version to 1.0.0 Results: Up-to-date Put organization info Motivation: Using organization in POM reduces effort for maintaining it. Modifications: Put organization info and remove developers section. Results: Less effort to maintain pom.xml. Fix Github CI when PR is created from Fork Motivation: Github actions on PRs created from a fork were failing due to restricted access to repository variables. The problem was that the failing actions were trying to access these variables, which is not allowed. Modifications: To fix this issue, I removed the variable access from the Github actions. Results: After these changes, the Github actions are now working as expected, even when PRs are created from a fork. Resolves asyncer-io#70 Unsigned long fields in OkMessage converted to unsigned strings in toString method Add Pull Request Template Motivation: The absence of a Pull Request (PR) template is not ideal as it requires contributors to manually format their PR messages. Having a PR template will standardize the format of PR messages and improve the PR review process. Modification: Added a PR template Result: All Prs will now follow a consistent format, which will make review process more efficient and effective. Move PR template to correct place Motivation: PR template is not applied since it was not in correct place Modification: Move PR template to correct place Result: Working PR template Adding jobs for Java 11 and Java 17. (asyncer-io#80) Motivation: Currently compatibility tests are only for Java 8. Need to add more tests for other LTS version Java 11 & 11. Modifications: Added new jobs for Java v11 & v 17 in unit-tests workflow and removed -WError argument in POM.xml for maven-compiler-plugin to fix failing Java 17 build. Result: Jobs for Java 8, 11, 17 run to check compatibility --------- Co-authored-by: Saurabh Yadav <saurabh.yadav@klarna.com> Remove intellij-style.xml (asyncer-io#67) Motivation: Meaning less to include style.xml in project root. since we have no check-style in CI/CD phase. Modifications: Remove style.xml Results: Clean up Use latest maven (asyncer-io#84) Using matrix version to build job Update .github/workflows/unit-tests.yml Co-authored-by: jchrys <jchrys@me.com> Signed-off-by: saurabhyadav1985 <49230235+saurabhyadav1985@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Better use latest maven
Modification:
Use Maven 3.9.1 to build & test
Result:
up-to-date with Maven