Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build jobs using a matrix #86

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Conversation

saurabhyadav1985
Copy link
Contributor

@saurabhyadav1985 saurabhyadav1985 commented Apr 9, 2023

Motivation:
Reduce duplication in the GitHub Actions workflow unit-tests #83

Modification:
Refactored three jobs into one, now will build using strategy.matrix.version

Result:
Jobs should build for Java 8, 11 and 17 version.

Copy link
Collaborator

@jchrys jchrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR! Just one small thing.

  • Could you please rebase and squash the changes to create a single commit?

Could you please add a line separator in the commit message, as shown below, to improve readability?

Motivation: 
Reduce ...

Modification: 
Refactored...

Result: 
Jobs...

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
saurabhyadav1985 and others added 3 commits April 9, 2023 12:49
Co-authored-by: jchrys <jchrys@me.com>
Signed-off-by: saurabhyadav1985 <49230235+saurabhyadav1985@users.noreply.github.com>
@saurabhyadav1985
Copy link
Contributor Author

Hey can you please delete my fork so I can fork again and raise PR as I am unable to squash into one commit

@jchrys
Copy link
Collaborator

jchrys commented Apr 9, 2023

You don't need to delete your fork to achieve this; you can do it by yourself.

Try the following steps:

$ git checkout {yourbranch}
$ git rebase -i trunk
Squash all commits except the top one.
Create a commit message.
$ git push --force

@jchrys jchrys merged commit 819ba92 into asyncer-io:trunk Apr 11, 2023
4 checks passed
@jchrys
Copy link
Collaborator

jchrys commented Apr 11, 2023

I squash merged to make it a single commit.
Thanks a lot!

@jchrys jchrys added this to the 1.0.1 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants