-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify build jobs using a matrix #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your PR! Just one small thing.
- Could you please rebase and squash the changes to create a single commit?
Could you please add a line separator in the commit message, as shown below, to improve readability?
Motivation:
Reduce ...
Modification:
Refactored...
Result:
Jobs...
Co-authored-by: jchrys <jchrys@me.com> Signed-off-by: saurabhyadav1985 <49230235+saurabhyadav1985@users.noreply.github.com>
Hey can you please delete my fork so I can fork again and raise PR as I am unable to squash into one commit |
You don't need to delete your fork to achieve this; you can do it by yourself. Try the following steps: $ git checkout {yourbranch} |
I squash merged to make it a single commit. |
Motivation:
Reduce duplication in the GitHub Actions workflow unit-tests #83
Modification:
Refactored three jobs into one, now will build using strategy.matrix.version
Result:
Jobs should build for Java 8, 11 and 17 version.