Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wrapped interface #88

Closed
wants to merge 1 commit into from
Closed

Added Wrapped interface #88

wants to merge 1 commit into from

Conversation

svats0001
Copy link
Contributor

@svats0001 svats0001 commented Apr 13, 2023

Hi @jchrys,

#65

EDIT: The Wrapped interface already exists in the io.r2dbc.spi package, I think by support you meant the implementation?

I created the Wrapped optional interface. I'm unsure if I need to implement this anywhere or if it's entirely up to the end user.

Motivation: To add support for the Wrapped optional interface in the R2DBC specification so that we can access an instance of a resource that has been wrapped or for implementers to expose wrapped resources.

Modification: Added the Wrapped interface into the io.asyncer.r2dbc.mysql package.

Result: We can now access an instance of a resource that has been wrapped or expose wrapped resources.

@jchrys
Copy link
Collaborator

jchrys commented Apr 13, 2023

Hello, @svats0001.
Yes, You're correct. we need to implement it.
I think we can refer mysql-connector-j's implementation. (https://javadoc.io/doc/com.mysql/mysql-connector-j/latest/index.html)
However, as it's an optional feature and we have not received any requests from users for this functionality, we do not need to prioritize it immediately. That being said, if you are interested and have the bandwidth to work on this feature, we would certainly appreciate your efforts.

Thanks!

@svats0001
Copy link
Contributor Author

I'll have a look at implementing it when possible. I'll close this PR now.

@svats0001 svats0001 closed this Apr 14, 2023
@svats0001 svats0001 deleted the wrapped branch April 19, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants