Fixing warnings (#1771)

asynkron · Sep 25, 2022 · 35a94b3 · 35a94b3
1 parent dc7ec97
commit 35a94b3
Show file tree

Hide file tree

Showing 15 changed files with 19 additions and 13 deletions.
diff --git a/benchmarks/AutoClusterBenchmark/AutoClusterBenchmark.csproj b/benchmarks/AutoClusterBenchmark/AutoClusterBenchmark.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
         <OutputType>Exe</OutputType>
         <LangVersion>10</LangVersion>

diff --git a/benchmarks/ClusterBenchmark/ClusterBenchmark.csproj b/benchmarks/ClusterBenchmark/ClusterBenchmark.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
         <OutputType>Exe</OutputType>
         <LangVersion>10</LangVersion>

diff --git a/benchmarks/GossipBenchmark/Messages/Messages.csproj b/benchmarks/GossipBenchmark/Messages/Messages.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <NoWarn>8981</NoWarn>
     <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
   </PropertyGroup>
   <ItemGroup>

diff --git a/benchmarks/RemoteBenchmark/Messages/Messages.csproj b/benchmarks/RemoteBenchmark/Messages/Messages.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
   <PropertyGroup>
+    <NoWarn>8981</NoWarn>
     <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
   </PropertyGroup>
   <ItemGroup>

diff --git a/src/Proto.Actor/Proto.Actor.csproj b/src/Proto.Actor/Proto.Actor.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <RootNamespace>Proto</RootNamespace>
         <Nullable>enable</Nullable>
         <IsPackable>true</IsPackable>

diff --git a/src/Proto.Cluster.CodeGen/Proto.Cluster.CodeGen.csproj b/src/Proto.Cluster.CodeGen/Proto.Cluster.CodeGen.csproj
@@ -27,7 +27,7 @@
 
     <ItemGroup>
         <PackageReference Include="Handlebars.Net" Version="2.0.9"/>
-        <PackageReference Include="MinVer" Version="2.5.0" PrivateAssets="All"/>
+
         <PackageReference Update="Microsoft.SourceLink.GitHub" Version="1.1.1"/>
         <PackageReference Include="protobuf-net" Version="3.0.101"/>
         <PackageReference Include="protobuf-net.Reflection" Version="3.0.101"/>

diff --git a/src/Proto.Cluster/Proto.Cluster.csproj b/src/Proto.Cluster/Proto.Cluster.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <IsPackable>true</IsPackable>
         <Nullable>enable</Nullable>
         <LangVersion>10</LangVersion>

diff --git a/src/Proto.Cluster/PubSub/PubSubDeliveryException.cs b/src/Proto.Cluster/PubSub/PubSubDeliveryException.cs
@@ -8,7 +8,9 @@
 
 namespace Proto.Cluster.PubSub;
 
+#pragma warning disable RCS1194
 public class PubSubDeliveryException : Exception
+#pragma warning restore RCS1194
 {
     public PubSubDeliveryException(string? message) : base(message)
     {

diff --git a/src/Proto.Remote/Proto.Remote.csproj b/src/Proto.Remote/Proto.Remote.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <IsPackable>true</IsPackable>
         <Nullable>enable</Nullable>
         <LangVersion>10</LangVersion>

diff --git a/tests/Proto.Actor.Tests/PropsTests.cs b/tests/Proto.Actor.Tests/PropsTests.cs
@@ -107,10 +107,10 @@ public void Given_Props_When_WithSpawner_Then_mutate_Spawner()
         PID Spawner(ActorSystem s, string id, Props p, PID? parent, Action<IContext> callback) => new PID();
 
         var props = new Props();
-        var props2 = props.WithSpawner(Spawner);
+        var props2 = props.WithSpawner(Spawner!);
 
         Assert.NotEqual(props, props2);
-        Assert.Equal(Spawner, props2.Spawner);
+        Assert.Equal(Spawner!, props2.Spawner);
 
         Assert.Equal(props.Dispatcher, props2.Dispatcher);
         Assert.Equal(props.MailboxProducer, props2.MailboxProducer);

diff --git a/tests/Proto.Actor.Tests/Proto.Actor.Tests.csproj b/tests/Proto.Actor.Tests/Proto.Actor.Tests.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
     <PropertyGroup Label="Configuration">
+        <NoWarn>8981</NoWarn>
         <RootNamespace>Proto.Tests</RootNamespace>
         <LangVersion>10</LangVersion>
         <OutputType>Library</OutputType>

diff --git a/tests/Proto.Cluster.PartitionIdentity.Tests/Proto.Cluster.PartitionIdentity.Tests.csproj b/tests/Proto.Cluster.PartitionIdentity.Tests/Proto.Cluster.PartitionIdentity.Tests.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
@@ -12,10 +13,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-            <PrivateAssets>all</PrivateAssets>
-        </PackageReference>
+
         <PackageReference Include="coverlet.collector" Version="3.1.2">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>

diff --git a/tests/Proto.Cluster.Tests/Proto.Cluster.Tests.csproj b/tests/Proto.Cluster.Tests/Proto.Cluster.Tests.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0">
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <LangVersion>10</LangVersion>
         <TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
     </PropertyGroup>

diff --git a/tests/Proto.OpenTelemetry.Tests/Proto.OpenTelemetry.Tests.csproj b/tests/Proto.OpenTelemetry.Tests/Proto.OpenTelemetry.Tests.csproj
@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <Nullable>enable</Nullable>
         <LangVersion>10</LangVersion>
         <IsPackable>false</IsPackable>
@@ -16,13 +17,8 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
         <PackageReference Include="OpenTelemetry" Version="1.2.0" />
-        <PackageReference Include="xunit" Version="2.4.1" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
-            <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-            <PrivateAssets>all</PrivateAssets>
-        </PackageReference>
+
         <PackageReference Include="coverlet.collector" Version="3.1.1">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>

diff --git a/tests/Proto.Remote.Tests.Messages/Proto.Remote.Tests.Messages.csproj b/tests/Proto.Remote.Tests.Messages/Proto.Remote.Tests.Messages.csproj
@@ -1,5 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
+        <NoWarn>8981</NoWarn>
         <IsTestProject>false</IsTestProject>
         <LangVersion>10</LangVersion>
         <TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>