Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster request timeout now throws TimeoutException #1727

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Cluster request timeout now throws TimeoutException #1727

merged 7 commits into from
Jul 29, 2022

Conversation

marcinbudny
Copy link
Contributor

Description

Closes #1712

Cluster requests now throw TimeoutException on timeout. This is a breaking change. Old behavior can be enabled via ClusterConfig.WithLegacyRequestTimeoutBehavior()

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit f7c577a into asynkron:dev Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeralsing rogeralsing rogeralsing left review comments

@mhelleborg mhelleborg mhelleborg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Cluster.RequestAsync throw exception instead of returning null
4 participants
@marcinbudny @rogeralsing @mhelleborg @marcinbudny-etteplan