Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry request on DeadLetterResponse #1822

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

michalnarwojsz
Copy link
Contributor

Description

Instead of failing virtual actor request when DeadLetterResponse is received, retry the request.

Also make sure that DeadLetterResponse is not returned to client when request is called with object as type parameter.
Fixes #1799

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Instead of failing virtual actor request when DeadLetterResponse is received, retry the request.

Also make sure that DeadLetterResponse is not returned to client when request is called with object as type parameter.

Fixes asynkron#1799
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2022

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit 6c27bc8 into asynkron:dev Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated grains don't handle DeadLetterResponse
3 participants