Allow ISenderContext.Request to propagate headers #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Request. Previously it would wrap the passed in MessageEnvelope in a new message envelope when passed to request. This will send an updated MessageEnvelope which retains the existing headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
ISenderContext.Requestwould wrap the passed in MessageEnvelope in a new message envelope even if it already was one. This will send an updated MessageEnvelope which retains the existing headers.Purpose
This pull request is a:
Breaking change
If people have worked around the behaviour and un-nested envelopes in the actor, this will change nested
MessageEnvelopes to ble flattened to a single instance.Checklist