implement stopping when max number of restarts exceeds allowed number… #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskolnikoov
approved these changes
Jan 10, 2018
… in a period of time
tomliversidge
force-pushed
the
supervision_fix
branch
from
ac33096
to
cddaab1
Compare
|
I've fixed exponential backoff too.- should now reset if no errors have occurred within the window. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in a period of time
Uses the _withinTimeSpan value properly to fix #379
Reversed the control flow in the Restart section as it kept confusing me
Adds tests
NOTE: ExponentialBackoffStrategy looks wrong to me, we are lacking tests around this as the current two still pass, could do with some input into what this strategies behaviour is supposed to be.