Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media queries for Retina #25

Merged
merged 2 commits into from
Jul 9, 2013
Merged

Fix media queries for Retina #25

merged 2 commits into from
Jul 9, 2013

Conversation

roborn
Copy link
Contributor

@roborn roborn commented Jul 9, 2013

Retina queries aren't working as expected.

  • The media query for non-retina displays should use the max-resolution, instead of min-resolution;
  • The media query for Retina diplays should use the min value on the prefixed device-pixel-ratio.

Also, i added the Opera prefix on both queries.

- Set max values for non-retina displays
- Set min values for retina displays
@Snugug
Copy link
Member

Snugug commented Jul 9, 2013

Thank you. Here are some notes:

  • Please place the dppx queries first; unlike properties where the standard should come last to ensure the cascade, when working with or MQs, the standard should come first as each or gets read independently. Because of this, the sooner the standard is found, the better.
  • Please remove the Opera query. It was never really well supported by Opera and the dpi query will cover it.

@roborn
Copy link
Contributor Author

roborn commented Jul 9, 2013

Thanks for the feedback. Changes made :)

@Snugug
Copy link
Member

Snugug commented Jul 9, 2013

Thanks. I'll take a look when I'm back at my computer

Snugug added a commit that referenced this pull request Jul 9, 2013
Fix media queries for Retina
@Snugug Snugug merged commit 946305d into at-import:master Jul 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants