Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Sass 3.4 and Compass 1.0 (gemspec + Gemfile), updated tests control output #74

Merged
merged 3 commits into from
Aug 19, 2014

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented Aug 19, 2014

This is a swifter duplicate of #72.

Test output:

$ bundle list | grep 'sass\|compass'
  * compass (1.0.1)
  * compass-core (1.0.1)
  * compass-import-once (1.0.5)
  * sass (3.4.0)


$ bundle exec ruby .unit_tests.rb
...
14 tests, 14 assertions, 0 failures, 0 errors, 0 skips
ruby -v: ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]

Snugug added a commit that referenced this pull request Aug 19, 2014
Bump to Sass 3.4 and Compass 1.0 (gemspec + Gemfile), updated tests control output
@Snugug Snugug merged commit eae42e1 into at-import:2.x.x Aug 19, 2014
@Snugug
Copy link
Member

Snugug commented Aug 19, 2014

Resolves #72

@fubhy
Copy link

fubhy commented Aug 20, 2014

It would be great if you could leave a short notice (that you are going to take over) in the future before opening a new PR - As in giving me a chance to fix the PR. That way we don't run into this situation where two people work on the same stuff (wasting work time).

@lolmaus
Copy link
Contributor Author

lolmaus commented Aug 20, 2014

@fubhy I'm sorry your effort was wasted.

I did reference your PR from mine, though it doesn't spawn a notification. I could've been more explicit. @Snugug probably should've briefly explained the reason when closing your PR.

But when you saw your PR was closed, why didn't you look into why?

@lolmaus lolmaus deleted the patch-3 branch August 20, 2014 08:57
@fubhy
Copy link

fubhy commented Aug 20, 2014

Because I already started working on the next PR when @Snugug commented on it the first time ;)

@Snugug
Copy link
Member

Snugug commented Aug 20, 2014

@fubhy this is my bad and I'm sorry. Given the time of day I thought you would be unavailable.

@fubhy
Copy link

fubhy commented Aug 20, 2014

No worries. Many things came together here (including me not actually checking back with GH before continuing to work on it and no e-mail notifications for referenced PRs, etc.). After all it was just a simple PR with literally only like 10 lines of search&replace fixes for the tests. So really not tragic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants