-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add support for SPM #84
Conversation
@nsagnett What do you thin about this ? |
FWIW it is working for US even without the test passing so I will open a PR and let you fix your testing suite @nsagnett. |
Great job :) |
Many thanks @mackoj for your MR ! We will check it asap |
Any news on this? |
Apple have release in beta Swift 5.3 that allow to have ressources in packages 📦. I will make an update to add the ressources in the Package.swift file soonish. @choli If you want this to be made you should ask them directly and give them the link to this PR. |
Hi @nsagnett do you plan to add support for SPM ? Swift Package Manager exists since Swift 3.0(13 September 2016) and Swift 5.3 will add a lot of feature regarding SPM maybe it's time to revisit the support of SPM. https://github.com/apple/swift-evolution/blob/master/proposals/0271-package-manager-resources.md You can do complex ObjC support like RevenutCat did a great job for working with their ObjC code RevenueCat/Package.swift. As you can see in here https://swiftpackageindex.com there is a lot of package that are compatible with SPM. Since it's the first party option for package management you should really consider this. Thanks |
Hi @mackoj and thank you for the PR! Thanks again |
Hi there, any updates on this? |
@choli FWIW my branch is up to date with the 2.19.0 version of the SDK. |
Thanks @mackoj Is it also ready for extensions and watchOS? If not it doesn't really help us :( |
I didn't test for this but If not it is not compatible it might be pretty easy to patch. |
Maybe an easier approach could be build a xcframework then add it to SPM |
Hi there. Sorry for the delay, we are pretty busy lately. However, we are currently in the process of in depth reviewing of our SDKs, and be assured that SPM support is a requirement for it. In the meantime, if you need SPM support and the caveats @mackoj listed are not blocking for you, you are welcome to use this branch. Thanks for your contribution and discussions about this topic. |
Well, not moving forward... for 2% of devices... Source : https://developer.apple.com/support/app-store/
|
@kenji21 as an analytics solution, we aim at providing the most complete and exhaustive view of an app audience. |
This add support for Swift Package Manager it support both static and dynamic library.
Caveat
Todo
Today test are completely broken I have to make test compile and pass before submitting this.
In the future
Add support for these platforms :
There are 3 warnings lib to fix and 79 test errors to fix