Fix crushing when lidar poses are out of map #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@at-wat PTAL. |
[#876] FAILED on noeticTested on Alpine ROS [#876] FAILED on kineticTest failed[#876] FAILED on melodicTest failed |
[#877] PASSED on noeticTested on Alpine ROS [#877] PASSED on kineticAll tests passed[#877] PASSED on melodicAll tests passed |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 92.47% 92.35% -0.13%
==========================================
Files 36 36
Lines 1954 1961 +7
==========================================
+ Hits 1807 1811 +4
- Misses 147 150 +3
Continue to review full report at Codecov.
|
at-wat
reviewed
Oct 24, 2020
| { | ||
| max_movement_ = 0; | ||
| pos_ = 0; | ||
| return; |
There was a problem hiding this comment.
I think raycaster still should cast the ray by handling out-of-the-map as no-hit.
Otherwise, it causes a problem at the open end of the map.
(For very temporary fix, it is acceptable though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes crushing when lidar poses are out of map cloud.