trajectory_tracker: support PathWithVelocity #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coverage report build
This reverts commit 9470be6.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[#720] PASSED on indigoAll tests passed[#720] PASSED on kineticAll tests passed[#720] PASSED on lunarAll tests passed |
|
@ykoga-kyutech @jojo43 PTAL |
[#733] PASSED on indigoAll tests passed[#733] PASSED on kineticAll tests passed[#733] PASSED on lunarAll tests passed |
jojo43
approved these changes
Dec 20, 2018
| @@ -122,7 +125,8 @@ class TrackerNode | |||
| trajectory_tracker::Path2D path_; | |||
| std_msgs::Header path_header_; | |||
|
|
|||
| void cbPath(const nav_msgs::Path::ConstPtr&); | |||
| template <typename MSG_TYPE> | |||
| void cbPath(const typename MSG_TYPE::ConstPtr&); | |||
at-wat
commented
Dec 21, 2018
neonavigation_launch/package.xml
Outdated
| @@ -16,4 +16,5 @@ | |||
| <exec_depend>safety_limiter</exec_depend> | |||
| <exec_depend>tf2_ros</exec_depend> | |||
| <exec_depend>trajectory_tracker</exec_depend> | |||
| <!--exec_depend>trajectory_tracker_rviz_plugins</exec_depend--> | |||
There was a problem hiding this comment.
trajectory_tracker_rviz_plugins must be bloom released before merge
There was a problem hiding this comment.
Add TODO comment and merge for now.
ykoga-kyutech
approved these changes
Dec 21, 2018
| @@ -1,8 +1,11 @@ | |||
| <?xml version="1.0"?> | |||
| <launch> | |||
| <arg name="use_path_with_velocity" default="true" /> | |||
There was a problem hiding this comment.
For visualizing the path_velocity in Rviz by default, updating readme is better to clone https://github.com/at-wat/neonavigation_rviz_plugins/ .
[#734] PASSED on indigoAll tests passed[#734] PASSED on kineticAll tests passed[#734] PASSED on lunarAll tests passed |
[#735] PASSED on indigoAll tests passed[#735] FAILED on indigodocker build failed [#735] FAILED on kineticdocker build failed [#735] FAILED on lunardocker build failed |
[#736] PASSED on indigoAll tests passed[#736] PASSED on lunarAll tests passed[#736] PASSED on kineticAll tests passed |
|
at-wat/neonavigation_msgs#9 has been in the testing repository. Merging this. |
[#737] FAILED on indigoTest failed[#737] PASSED on kineticAll tests passed[#737] PASSED on lunarAll tests passed[#737] PASSED on indigoAll tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #239
fix #229
fix #245
require at-wat/neonavigation_msgs#9
Receive control commands from single topic
/path_velocity, equivalent to the combination of/pathand/speed, to make it easy to switch planner algorithm.