costmap_cspace: add linear_spread_min_cost parameter #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 88.65% 88.32% -0.34%
==========================================
Files 60 60
Lines 4435 4444 +9
==========================================
- Hits 3932 3925 -7
- Misses 503 519 +16
|
|
|
|
How about |
I think this is better, especially with the diagram. |
This comment has been minimized.
This comment has been minimized.
at-wat
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Could you add the parameter to
https://github.com/at-wat/neonavigation/blob/master/costmap_cspace/README.md#parameters-1
with the diagram?
Sorry I meant the diagram from the PR description. |
|
I meant to put the diagram in the PR description to README |
[507] PASSED on noeticAll tests passed |
nhatao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear_spread_min_costis the cost of edge grids spread from an occupied grid. (See Costmap3dLayerOutput.LinearSpreadMinCost)This parameter can make the costs of grids near obstacles higher to avoid other costs such as preferences overriding the costs of these grids.