Rename PointcloudAccumurator to PointcloudAccumulator #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep PointcloudAccumurator for backward compatibility.
at-wat
reviewed
Aug 28, 2021
Comment on lines
113
to
114
| template <typename T> | ||
| using PointcloudAccumurator = PointcloudAccumulator<T>; |
There was a problem hiding this comment.
It would be better to mark as deprecated using C++14 [[deprecated]] attribute.
https://en.cppreference.com/w/cpp/language/attributes/deprecated
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 90.70% 90.76% +0.06%
==========================================
Files 58 59 +1
Lines 4486 4496 +10
==========================================
+ Hits 4069 4081 +12
+ Misses 417 415 -2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[117] PASSED on noeticAll tests passed[117] PASSED on melodicAll tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to fix a typo in the
PointcloudAccumuratorclass name. As this might break code relying on this class outside of this repository, I kept the original available. Maybe it can be completely removed when releasing the next major version. I also added some tests for thePointcloudAccumulatormethods.