planner_cspace: fix pose duplication on path interpolation #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 90.51% 90.51%
=======================================
Files 61 61
Lines 4556 4556
=======================================
Hits 4124 4124
Misses 432 432
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nhatao
approved these changes
Aug 5, 2022
| map_info.origin.position.y = -200.5; | ||
|
|
||
| CyclicVecFloat<3, 2> m_prev; | ||
| for (auto it = out.begin(); it != out.end(); ++it) |
There was a problem hiding this comment.
++it requires non-const.
BTW, rewrote as range-based for.
| */ | ||
|
|
||
| #include <list> | ||
| #include <iostream> |
[226] PASSED on melodicAll tests passed |
[226] PASSED on noeticAll tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output path might contain duplicated poses due to interpolation logic and quantization error.