Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in options parsing #51

Closed
wants to merge 1 commit into from
Closed

Conversation

KSDaemon
Copy link
Contributor

Hi! There is one mistake in parsing options. I fixed!

@KSDaemon
Copy link
Contributor Author

Will be great, if you can publish a new release!

@DevNebulae
Copy link

DevNebulae commented Mar 17, 2017

I can confirm that this fix works with webpack version 2.1.1. Would love to see this in the main branch. Note, fixes issue #50.

@KSDaemon
Copy link
Contributor Author

Great! Two good things done is better than one :)

@at0g
Copy link
Owner

at0g commented Mar 18, 2017

@KSDaemon
To preserve backwards compatibility, the changes from PR #48 (that this PR depends on) have been reverted and the update released as v2.4.8.
Please feel free to update and reopen this PR if you like.

@at0g at0g closed this Mar 18, 2017
@KSDaemon
Copy link
Contributor Author

Well... As of:

DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.

I don't see any reason, why not to switch to getOptions().
Sorry, if i don't correctly understand, what you mean under backwards compatibility... If you mean supporting both webpack 1.x and 2.x versions... Current version works great with webpack 1.x, and development of webpack 1.x itself was stopped. I think we can switch to 2.x. Your opinions?

@at0g
Copy link
Owner

at0g commented Mar 20, 2017

regarding the backwards compatibility: loader-utils@1.xrequires a newer version of node, so has the potential to break existing installs (see #50) - making the switch to getOptions a major version bump for this project.
To avoid breaking (anymore) existing installs using 3.x of this project, I've reverted the latest updates and released that as the latest patch on 3.x.

@KSDaemon
Copy link
Contributor Author

Now i see! Agree. Thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants