Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

len(Packet) not handled correctly for PCM throughput #29

Closed
pferrill opened this issue Mar 24, 2022 · 7 comments
Closed

len(Packet) not handled correctly for PCM throughput #29

pferrill opened this issue Mar 24, 2022 · 7 comments
Assignees

Comments

@pferrill
Copy link

Index packets appear to be malformed.

Input file:

image

Output file:

image

@mcferrill
Copy link
Member

Unable to reproduce. Is the source file valid?

@pferrill
Copy link
Author

pferrill commented Apr 5, 2022

The source file had a mangled index which is why I was trying to reindex. From the screenshot above it appears that the wrong packets are being used for the index. I believe the input file was valid in form but the index packets had wrong pointers.

@mcferrill
Copy link
Member

From the screenshot above it appears that the wrong packets are being used for the index.

Which screenshot? Are you talking about the input file or the output?

I believe the input file was valid in form but the index packets had wrong pointers.

reindex ignores existing index packets. The file either is or isn't valid, and those channel numbers / types look suspect.

@pferrill
Copy link
Author

Two screenshots comparing input and output files. Input/output refers to the file prior to using Bob's ig106Dub program, which has since been fixed.

I would agree that the index packets have bogus channel numbers - probably due to the offsets being wrong. The basic file structure appears to be valid however.

I would agree if the index packets are broken the file in general is not valid. However, just reading Chapter 10 headers and ignoring indexes should work based on my cursory examination.

@pferrill
Copy link
Author

Data in A429 channels is not being properly copied from source file to output file.

First A429 Packet in input file TST.ch10:

Offset : 0x0000000000022D14
ChanID : 33 Sync : 0xEB25 PktLen : 136
DataLen : 108 Ver : 6 Seq : 111
REFTIME ERR : 0 OVERFLOW ERR: 0 CHKSUM IND : 32Bit
SECOND HDR : NO TIME SOURCE : PktHdr 48-Bit Ref Time
Type : 56 A429 TimeLo : 0x48EB TimeMid : 0x8FC6
TimeHi : 0x0000 ChkSum : 27636

Packet's Data Efficiency : 79.4118
Packet's Relative Time Counter : 2412136683
Computed IRIG Time: 064:14:29:11:010607 Delta Time: 10.608 msec.

ARINC429 CHAN SPEC :0x0000000D
Number of Messages :13

PACKET HEADER:
00000000 EB25 0021 0088 0000 006C 0000 6F06 3803
00000010 48EB 8FC6 0000 6BF4

PACKET DATA:

Subch Data Label Speed PErr FErr Gap Time Computed IRIG Time
0 A000010F (360) HI 0 0 0 064:14:29:11:010607
0 A00001AF (365) HI 0 0 3750 064:14:29:11:010982
0 0048E137 (354) HI 0 0 3750 064:14:29:11:011357
0 A000116B (326) HI 0 0 42300 064:14:29:11:015587
0 A00061EB (327) HI 0 0 3750 064:14:29:11:015962
0 BFFFB11B (330) HI 0 0 3750 064:14:29:11:016337
0 A000017B (336) HI 0 0 3750 064:14:29:11:016712
0 200001FB (337) HI 0 0 3750 064:14:29:11:017087
0 A00001BB (335) HI 0 0 10201 064:14:29:11:018107
0 A00AB19B (331) HI 0 0 3750 064:14:29:11:018482
0 2000015B (332) HI 0 0 3750 064:14:29:11:018857
0 A00015DB (333) HI 0 0 3750 064:14:29:11:019232
0 200001CB (323) HI 0 0 3750 064:14:29:11:019607

PACKET TRAILER:
00000000 37D1 21F5

First A429 channel from output file Out.ch10:

Offset : 0x000000000001C618
ChanID : 33 Sync : 0xEB25 PktLen : 32
DataLen : 4 Ver : 6 Seq : 111
REFTIME ERR : 0 OVERFLOW ERR: 0 CHKSUM IND : 32Bit
SECOND HDR : NO TIME SOURCE : PktHdr 48-Bit Ref Time
Type : 56 A429 TimeLo : 0x48EB TimeMid : 0x8FC6
TimeHi : 0x0000 ChkSum : 27428

Packet's Data Efficiency : 12.5
Packet's Relative Time Counter : 2412136683
Computed IRIG Time: 064:14:29:11:010607 Delta Time: 10.608 msec.

ARINC429 CHAN SPEC :0x0000000D
Number of Messages :13

PACKET HEADER:
00000000 EB25 0021 0020 0000 0004 0000 6F06 3803
00000010 48EB 8FC6 0000 6B24

PACKET DATA:

Subch Data Label Speed PErr FErr Gap Time Computed IRIG Time
0 0083EB25 (244) LO 0 0 13 064:14:29:11:010609
0 00000004 (040) LO 0 0 32 064:14:29:11:010612
66 8FA7B89C (071) LO 0 0 243718 064:14:29:11:034984
46 00008000 (000) LO 0 0 524288 064:14:29:11:087412
0 0020EB25 (244) LO 0 0 32768 064:14:29:11:090689
0 00000004 (040) LO 0 0 32 064:14:29:11:090692
56 8FC73BD2 (113) LO 0 0 226310 064:14:29:11:113323
99 0000001B (330) LO 0 0 720896 064:14:29:11:185413
0 0021EB25 (244) LO 0 0 27 064:14:29:11:185416
0 00000004 (040) LO 0 0 32 064:14:29:11:185419
56 8FC7CFF1 (217) LO 0 0 225286 064:14:29:11:207948
243 00000005 (240) HI 0 0 720896 064:14:29:11:280037
0 0057EB25 (244) LO 0 0 5 064:14:29:11:280038

PACKET TRAILER:
00000000 000D 0000

Data files uploaded to Teams under ATAC Tools Python file area

@mcferrill
Copy link
Member

What command produced these results?

@mcferrill
Copy link
Member

For reference: the original reported behavior is c10 reindex hanging on the "output" file from the OP.

It sounds like you're using an outdated version of c10-tools. When I attempt a reindex on that tst.ch10 file it fails (probably on a corrupt packet). c10 inspect shows errors in channel 87 (PCM throughput) in 4 packets:

image

If you could retest with the current version (c10 --version should be 1.1.2) and let me know if you see something different that would be great.

@mcferrill mcferrill transferred this issue from atac/c10-tools Apr 19, 2022
@mcferrill mcferrill changed the title C10-Reindex problem len(Packet) not handled correctly for PCM throughput Apr 19, 2022
mcferrill added a commit that referenced this issue Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants