Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to read from STDIN too #7

Merged
merged 1 commit into from
May 6, 2019

Conversation

seventyeight
Copy link
Contributor

Really like this project. But i miss the way to handle things via STDIN. For instance now you can do this: curl -s https://i.redd.it/06ozylnfmm521.jpg | ./target/release/viu -w 70
It is the first time coding some Rust. Any review is welcome.

@atanunq
Copy link
Owner

atanunq commented May 5, 2019

Wow, this is amazing! Thank you so much for taking the time. I am definitely adding your idea to the project. However, I am afraid this will take some time. I am close to releasing a major update that deals with animated GIFs and I have already changed every possible line of code there is. After that is done I will test out and include your changes.
Thanks again for contributing!

@atanunq atanunq merged commit 6dc3f64 into atanunq:master May 6, 2019
@atanunq
Copy link
Owner

atanunq commented May 6, 2019

Hey, @seventyeight! Your code is now live. I did alter a part of it to work around the changes needed for gif support, but the core stdin-reading logic is there. A thing I noticed is that you did not match some vital .unwrap() calls which is pretty important when app failure must be avoided. Overall great job and I look forward to hearing your ideas again!

@seventyeight
Copy link
Contributor Author

Awesome! Thanks for the feedback. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants