Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method to automatically bind xpadneo #33

Closed
atar-axis opened this issue May 23, 2018 · 1 comment
Closed

New method to automatically bind xpadneo #33

atar-axis opened this issue May 23, 2018 · 1 comment

Comments

@atar-axis
Copy link
Owner

atar-axis commented May 23, 2018

Until now we had two possibilites to automatically load and bind xpadneo:

  1. Add it to the hid_have_special_driver struct (see this patch)

  2. Using a UDEV rules to unbind the gamepad from hid_generic and bind it to hid_xpadneo as soon as the gamepad is added (see here)

Some of you may have already recognized that our buildsystem (the Taskfile) does no longer work because it is no longer possible to apply the HID patch, this is because of this commit:

torvalds/linux@e04a044#diff-88d50bd989bbdf3bbd2f3c5dcd4edcb9

As with 4.16rc1 Linux finally removed the hid_have_special_driver struct (and I am very happy about that!). It means that since 4.16rc1 you will not need longer any of those two methods above - the kernel will now load the special driver automatically.

Unfortunately that also means that we would have to distinguish between kernel version before 4.16 and after on the current master branch (the one with the Task Buildsystem). We would have to apply the HIDcore patch before 4.16 and not after 4.16.

I think it's time to switch to DKMS within the next days instead of fixing this.
(But I will keep the UDEV rule at the DKMS branch for older kernels)

@atar-axis atar-axis added 0 | type: bug Something isn't working 0 | type: enhancement New feature or request labels May 23, 2018
@atar-axis atar-axis changed the title Use the new HID_QUIRK_HAVE_SPECIAL_DRIVER to bind xpadneo Use the new method to automatically bind xpadneo May 23, 2018
@atar-axis atar-axis changed the title Use the new method to automatically bind xpadneo New method to automatically bind xpadneo May 23, 2018
@atar-axis atar-axis added wontfix and removed 0 | type: enhancement New feature or request labels May 23, 2018
atar-axis added a commit that referenced this issue May 23, 2018
atar-axis added a commit that referenced this issue May 23, 2018
@atar-axis atar-axis removed 0 | type: bug Something isn't working wontfix labels May 23, 2018
@atar-axis
Copy link
Owner Author

atar-axis commented May 24, 2018

closing with 2ba178b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant