Added overload of WebView::LoadHtml with missing parameter String^ url, as provided by CEF. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' to Winforms and Wpf control. This is necessary, because the current implementation of LoadHtml doesn't give access to the paremter as exposed by _clientAdapter->GetCefBrowser()->GetMainFrame()->LoadString. Instead, the parameter is hardcoded to "about:blank". This has 2 disadvanteges with no workaround: 1. html code with relative paths to resources are not possible. 2. html code with (even absolute )paths to local files(images) are not possible, due to different security zone.
|
Thanks. I haven't had much time for CefSharp lately but when I do I'll merge this. |
|
Thank you very much. I really appreciate your effort. Von: anthony [mailto:notifications@github.com] Thanks. I haven't had much time for CefSharp lately but when I do I'll merge this. — Das Bild wurde vom Absender entfernt. |
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overload of method LoadHtml with additional parameter 'string^ url' to to Winforms and Wpf control.
This is necessary, because the current implementation of LoadHtml doesn't give access to the paremter as exposed by _clientAdapter->GetCefBrowser()->GetMainFrame()->LoadString.
Instead, the parameter is hardcoded to "about:blank". This has 2 disadvanteges with no workaround: