Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return "" instead of null as value of string-based field component #581

Closed
YevgeniyShunevych opened this issue Nov 19, 2021 · 0 comments
Closed

Comments

@YevgeniyShunevych
Copy link
Member

YevgeniyShunevych commented Nov 19, 2021

In Atata v1, when input or content field is empty, null is returned as a value. It is more logical and consistent to return an empty string instead.

Migration to v2.0.0

Take into account to change the assertions like:

SomeInput.Should.BeNull();

to:

SomeInput.Should.BeEmpty();
@YevgeniyShunevych YevgeniyShunevych added this to the 2.0.0 milestone Nov 19, 2021
@YevgeniyShunevych YevgeniyShunevych self-assigned this Nov 19, 2021
@YevgeniyShunevych YevgeniyShunevych changed the title Return "" instead of null as value of Content and string-based Value component properties Return "" instead of null as value of string-based Value field component properties Nov 19, 2021
@YevgeniyShunevych YevgeniyShunevych changed the title Return "" instead of null as value of string-based Value field component properties Return "" instead of null as value of string-based field component Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant