Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: SA1649 File Name Must Match Type Name #32

Closed
kimlundjohansen opened this issue Dec 23, 2020 · 6 comments
Closed

Rule: SA1649 File Name Must Match Type Name #32

kimlundjohansen opened this issue Dec 23, 2020 · 6 comments
Assignees

Comments

@kimlundjohansen
Copy link

Rule summary

Value
Title SA1649FileNameMustMatchTypeName
CheckId SA1649
Category Documentation Rules
Link https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1649.md

What is the problem

We name EndpointFixture<TRequest, TResource> as EndpointFixture{TRequest,TResponse} - the rule dowsn't allow it.

Suggestion

disable this rule in root .editorconfig with dotnet_diagnostic.SA1649.severity = none

@cjakobsen
Copy link
Contributor

Investigate why this does not work. According to the documentation it should be allowed if file naming styles are setup correct (see here https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/Configuration.md#file-naming-conventions)

@egil
Copy link
Contributor

egil commented Jan 26, 2021

This rule also overlaps with of the Meziantou.Analyzer (#26), so this or that should be completely disabled.

@davidkallesen
Copy link
Collaborator

@egil or @cjakobsen can you verify this SA1649 has exact behaviour as MA0048

Then I will suggest root/.editorconfig with severity = error

@cjakobsen
Copy link
Contributor

@davidkallesen From what I can tell after testing it they are the same. There are more information in SA1649 so I suggest we keep that and suppress MA0048.

@egil
Copy link
Contributor

egil commented Mar 5, 2021

This replaces the decision from #26 .

@davidkallesen
Copy link
Collaborator

Commit: 522c1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants