This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Replace deprecated linters #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace deprecated `maligned` linter with `govet: fieldalignment` - replace deprecated `scopelint` linter with `exportloopref` refs GH-218
|
CI failures are expected due to golangci-lint config file changes. |
atc0005
added a commit
that referenced
this pull request
Apr 15, 2021
Disable govet:fieldalignment, re-enable deprecated maligned linter until the Go team offers more control over the types of checks provided by the fieldalignment linter or golangci-lint does so. refs GH-218 refs GH-219 refs GH-220 refs atc0005/go-ci#302
atc0005
added a commit
that referenced
this pull request
Apr 15, 2021
Disable govet:fieldalignment, re-enable deprecated maligned linter until the Go team offers more control over the types of checks provided by the fieldalignment linter or golangci-lint does so. - refs GH-218 - refs GH-219 - refs GH-220 - refs atc0005/go-ci#302
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malignedlinter withgovet: fieldalignmentscopelintlinter withexportloopreffixes GH-218