Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deprecated maligned linter #244

Closed
atc0005 opened this issue Jun 12, 2021 · 0 comments · Fixed by #245
Closed

Restore deprecated maligned linter #244

atc0005 opened this issue Jun 12, 2021 · 0 comments · Fixed by #245
Assignees
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 12, 2021

The field alignment linting has its uses, but the fieldalignment: struct with X pointer bytes could be Y (govet) linting errors are maddening. Unfortunately it doesn't appear that there is a way to disable just the pointer bytes linting error while keeping the fieldalignment: struct with X bytes could be Y (govet) one active.

For now, I'm opting to re-enable the deprecated maligned linter.

refs GH-203
refs atc0005/go-ci#302

@atc0005 atc0005 added this to the Next Release milestone Jun 12, 2021
@atc0005 atc0005 self-assigned this Jun 12, 2021
atc0005 added a commit that referenced this issue Jun 12, 2021
- Enable `maligned` linter
- Disable `fieldalignment` settings
  - until the Go team offers more control over the types
    of checks provided by the `fieldalignment` linter or
    `golangci-lint` does so.

refs GH-244
refs atc0005/go-ci#302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant