Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile | go get executable installation deprecated #491

Closed
atc0005 opened this issue Nov 4, 2021 · 0 comments · Fixed by #492
Closed

Makefile | go get executable installation deprecated #491

atc0005 opened this issue Nov 4, 2021 · 0 comments · Fixed by #492
Assignees
@atc0005
Labels
bug Something isn't working builds
Milestone
v0.26.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Nov 4, 2021

From the Lint codebase using Makefile GHAW output:

go get: installing executables with 'go get' in module mode is deprecated.
	Use 'go install pkg@version' instead.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

Relevant block:

check-vmware/Makefile

Lines 116 to 125 in aaf8376

.PHONY: lintinstall
## lintinstall: install common linting tools
# https://github.com/golang/go/issues/30515#issuecomment-582044819
lintinstall:
@echo "Installing linting tools"
@export PATH="${PATH}:$(go env GOPATH)/bin"
@echo "Explicitly enabling Go modules mode per command"
(cd; GO111MODULE="on" go get honnef.co/go/tools/cmd/staticcheck)

@atc0005 atc0005 added bug Something isn't working builds labels Nov 4, 2021
@atc0005 atc0005 added this to the Next Release milestone Nov 4, 2021
@atc0005 atc0005 self-assigned this Nov 4, 2021
atc0005 added a commit that referenced this issue Nov 4, 2021
@atc0005
Update lintinstall recipe to use go install
f85f1b5 
Replace deprecated `go get` syntax. Per official docs, the
new syntax used builds the tool in module-aware mode. This
accomplishes what we were using before but with a supported
(and cleaner) syntax.

refs GH-491
refs https://pkg.go.dev/cmd/go
@atc0005 atc0005 mentioned this issue Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
bug Something isn't working builds
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging a pull request may close this issue.

Update lintinstall recipe to use go install atc0005/check-vmware
1 participant
@atc0005