Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should snapshots for powered off VMs be ignored by default? #79

Closed
atc0005 opened this issue Jan 24, 2021 · 0 comments
Closed

Should snapshots for powered off VMs be ignored by default? #79

atc0005 opened this issue Jan 24, 2021 · 0 comments
Assignees
@atc0005
Labels
documentation Improvements or additions to documentation question Further information is requested snapshot virtual machine

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 24, 2021 •
edited

Currently this is not the assumption. Snapshots are subject to both Age and Size checks by default, regardless of a VM's power state. While ignoring issues for powered off VMs by default makes sense to me in some cases (e.g., VMware Tools versions), ignoring powered off VMs seems more risky when dealing with snapshots.

Opening this issue to invite feedback from others.

Snippet currently used in the README, cmd-specific doc files:

The current design of this plugin is to evaluate all Virtual Machines, whether powered off or powered on. If you have a use case for evaluating only powered on VMs by default, please add a comment to GH-79 providing some details for your use-case. In our environment, I have yet to see a need to only evaluate powered on VMs for old snapshots. For cases where the snapshots needed to be ignored, we added the VM to the ignore list. We then relied on datastore usage monitoring to let us know when space was becoming an issue.
@atc0005 atc0005 added the question Further information is requested label Jan 24, 2021
@atc0005 atc0005 added this to the Future milestone Jan 24, 2021
@atc0005 atc0005 self-assigned this Jan 24, 2021
@atc0005 atc0005 pinned this issue Jan 24, 2021
@atc0005 atc0005 changed the title Should powered off VMs be ignored by default for snapshots Age and Size checks? Should snapshots for powered off VMs be ignored by default? Jan 24, 2021
atc0005 added a commit that referenced this issue Jan 24, 2021
@atc0005
Add GH link - snapshots powerstate eval feedback
2d5fa09 
Replace "please submit an issue" request with direct link
to a GitHub issue intended specifically to collect feedback
on the topic. This seems more organized than opening a new
issue for each response.

refs GH-79
@atc0005 atc0005 mentioned this issue Jan 24, 2021
Merged
@atc0005 atc0005 added the documentation Improvements or additions to documentation label Jan 26, 2021
@atc0005 atc0005 closed this as completed Mar 28, 2021
Repository owner locked and limited conversation to collaborators Mar 28, 2021
@atc0005 atc0005 unpinned this issue Mar 28, 2021
@atc0005 atc0005 removed this from the Future milestone Mar 28, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees

@atc0005 atc0005

Labels
documentation Improvements or additions to documentation question Further information is requested snapshot virtual machine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atc0005